Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement help dropdown for new header #2986

Merged
merged 10 commits into from
Jul 8, 2024
Merged

feat: Implement help dropdown for new header #2986

merged 10 commits into from
Jul 8, 2024

Conversation

spalmurray-codecov
Copy link
Member

@spalmurray-codecov spalmurray-codecov commented Jul 4, 2024 •
edited
Loading

Implements the help dropdown for new header, consolidating many of our support links into one nice package. The Share feedback button is the one non-link, this button opens the Sentry user feedback modal.

Also ran the generate-icons script, re-adding some icons that weren't added correctly.

Design

Closes codecov/engineering-team#1953

Screenshots

Screenshot 2024-07-05 at 10 16 01
Screenshot 2024-07-05 at 14 54 22

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (4a04934) to head (6bfa2cc).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #2986        +/-   ##
================================================
- Coverage   98.36000   98.32000   -0.04000     
================================================
  Files           898        903         +5     
  Lines         13342      13375        +33     
  Branches       3543       3499        -44     
================================================
+ Hits          13124      13151        +27     
- Misses          214        220         +6     
  Partials          4          4
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <ø> (ø)
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.53% <100.00%> (+0.12%) ⬆️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.24% <ø> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a04934...6bfa2cc. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 4, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
- Coverage   98.36%   98.32%   -0.05%     
==========================================
  Files         898      903       +5     
  Lines       13342    13375      +33     
  Branches     3568     3565       -3     
==========================================
+ Hits        13124    13151      +27     
- Misses        214      220       +6     
  Partials        4        4
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <ø> (ø)
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.53% <100.00%> (+0.12%) ⬆️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.24% <ø> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a04934...6bfa2cc. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (4a04934) to head (6bfa2cc).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
- Coverage   98.36%   98.32%   -0.05%     
==========================================
  Files         898      903       +5     
  Lines       13342    13375      +33     
  Branches     3497     3545      +48     
==========================================
+ Hits        13124    13151      +27     
- Misses        214      220       +6     
  Partials        4        4
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <ø> (ø)
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.53% <100.00%> (+0.12%) ⬆️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.24% <ø> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a04934...6bfa2cc. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (4a04934) to head (6bfa2cc).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
- Coverage   98.36%   98.32%   -0.05%     
==========================================
  Files         898      903       +5     
  Lines       13342    13375      +33     
  Branches     3543     3545       +2     
==========================================
+ Hits        13124    13151      +27     
- Misses        214      220       +6     
  Partials        4        4
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <ø> (ø)
...ts/Header/components/HelpDropdown/HelpDropdown.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.53% <100.00%> (+0.12%) ⬆️
Pages 99.15% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.24% <ø> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a04934...6bfa2cc. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 6.97kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.78MB 6.97kB ⬆️

@codecov-staging
Copy link

codecov-staging bot commented Jul 4, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 6.97kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.78MB 6.97kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 4, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d8f6aef Thu, 04 Jul 2024 20:54:39 GMT Expired Expired
e4e096e Thu, 04 Jul 2024 21:29:52 GMT Expired Expired
2fab8d7 Thu, 04 Jul 2024 21:42:17 GMT Expired Expired
4cffecd Thu, 04 Jul 2024 22:03:17 GMT Expired Expired
5ad6298 Fri, 05 Jul 2024 14:23:10 GMT Expired Expired
6bfa2cc Fri, 05 Jul 2024 19:03:34 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/new-header-help-dropdown branch 2 times, most recently from 4cffecd to 5ad6298 Compare July 5, 2024 14:09
@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 5, 2024 14:17
nicholas-codecov
nicholas-codecov approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/layouts/Header/components/HelpDropdown/HelpDropdown.spec.tsx Outdated Show resolved Hide resolved
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/new-header-help-dropdown branch from 5ad6298 to 6bfa2cc Compare July 5, 2024 18:52
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 2664937 Jul 8, 2024
57 of 61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/new-header-help-dropdown branch July 8, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-codecov nicholas-codecov nicholas-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement help dropdown for new header
3 participants
@spalmurray-codecov @codecov-releaser @nicholas-codecov